Adjust formula for lateral area's icon size
ClosedPublic

Authored by rizzitello on Tue, Nov 13, 3:49 AM.

Details

Summary

Use 72 denominator when calculating icon size; this lets up cover a better range of hi-DPI screens with the
correct size icon (48px)

Test Plan

before: (32 px @162 DPI)

after: (48px @162 DPI)

Diff Detail

Repository
R231 Atelier
Branch
lateralIconSize
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 5073
Build 5091: arc lint + arc unit
rizzitello requested review of this revision.Tue, Nov 13, 3:49 AM
rizzitello created this revision.
rizzitello edited the test plan for this revision. (Show Details)Tue, Nov 13, 4:01 AM
rizzitello edited the test plan for this revision. (Show Details)Tue, Nov 13, 4:04 AM
laysrodrigues requested changes to this revision.Tue, Nov 13, 11:40 AM
laysrodrigues added inline comments.
src/mainwindow.cpp
227

don't use magic numbers...

This revision now requires changes to proceed.Tue, Nov 13, 11:40 AM
rizzitello marked an inline comment as done.Tue, Nov 13, 12:18 PM
rizzitello added inline comments.
src/mainwindow.cpp
227

This is exactly how it was done before but using 96. While 96 is the "standard", using 72 works for the range of hi-dpi density better as the DPI varies slightly depending on physical size and native resolution. This fixes an issue where on the icon is correctly scaled on a 15" Hi-dpi display (DPI is 196) and its not scaled on another 28" Hi-Dpi display with a DPI of 162 . Both screens are 4k and both should be scaled. I adjusted the comment so the number is not magic its explained above the line. I didn't think it was worth making a variable to store a one time use number because as a said it was already done this way before my change.

rizzitello marked an inline comment as done.
rizzitello edited the test plan for this revision. (Show Details)
  • Rebase
patrickelectric accepted this revision.Sun, Nov 18, 12:28 PM
tcanabrava accepted this revision.Wed, Nov 21, 2:26 PM
laysrodrigues accepted this revision.Fri, Nov 23, 11:38 AM
This revision is now accepted and ready to land.Fri, Nov 23, 11:38 AM
rizzitello closed this revision.Fri, Nov 23, 2:42 PM