Differential D16851

Use Pointer for atcore object
AbandonedPublic
Actions

Authored by rizzitello on Nov 13 2018, 3:32 AM.

Details

Reviewers
tcanabrava
patrickelectric
laysrodrigues
Summary
  • Use a pointer for core object in the atcore instance widget

Diff Detail

Repository
R231 Atelier
Branch
pointToCore
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 4885
Build 4903: arc lint + arc unit
rizzitello requested review of this revision.Nov 13 2018, 3:32 AM
rizzitello created this revision.
rizzitello updated this revision to Diff 45387.Nov 13 2018, 3:36 AM
  • fix history
rizzitello retitled this revision from minor improvements to Use Pointer for atcore object.Nov 13 2018, 3:37 AM
rizzitello edited the summary of this revision. (Show Details)
rizzitello added reviewers: tcanabrava, patrickelectric, laysrodrigues.
rizzitello added a project: Atelier: General Development.
rizzitello added a subscriber: Atelier: General Development.
laysrodrigues added a comment.Nov 13 2018, 11:42 AM

I don't think that a pointer is necessary... so why?

rizzitello abandoned this revision.Nov 13 2018, 12:24 PM
In D16851#358914, @laysrodrigues wrote:

I don't think that a pointer is necessary... so why?

I think your right. This was done for some reasons related to multi machine but after some more thought this change could be cause more problems. I'm going to drop this diff.

Revision Contents
Changeset List

Diff 45387

View Options

src/widgets/atcoreinstancewidget.h

Loading...
View Options

src/widgets/atcoreinstancewidget.cpp

Loading...