Explicitly link and disable kcrash on kwin_wayland
ClosedPublic

Authored by davidedmundson on Nov 12 2018, 8:45 AM.

Details

Summary

Kwin tried to not use kcrash by not linking against it.

KIO now links against KCrash as we link against KIO we indirectly link
against KCrash and thus now link and launch kcrash on wayland. This
breaks coredump.

Arguably it should be fixed in KIO, but it's non-trivial.

The advantage of this approach is it allows us to enable drkonqi for
nested mode in the future, or make a non-gui drkonqi that just saves
logs.

Test Plan

Compiles

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Nov 12 2018, 8:45 AM
Restricted Application added a project: KWin. · View Herald TranscriptNov 12 2018, 8:45 AM
Restricted Application added a subscriber: kwin. · View Herald Transcript
davidedmundson requested review of this revision.Nov 12 2018, 8:45 AM

What does Q_CONSTRUCTOR_FUNCTION do? Documentation?

zzag added a subscriber: zzag.Nov 12 2018, 9:33 AM

What does Q_CONSTRUCTOR_FUNCTION do? Documentation?

It calls a given function (disableDrKonqi) before main().

romangg accepted this revision.Nov 12 2018, 9:35 AM
In D16834#358228, @zzag wrote:

What does Q_CONSTRUCTOR_FUNCTION do? Documentation?

It calls a given function (disableDrKonqi) before main().

Thanks. We should add a comment then to the macro. Couldn't directly find documentation about it online.

This revision is now accepted and ready to land.Nov 12 2018, 9:35 AM
zzag added a comment.Nov 12 2018, 9:53 AM

We should add a comment then to the macro.

I don't think we should do that. Instead it would be better to add a comment why we disable dr konqi.

This revision was automatically updated to reflect the committed changes.