Created a new Sublime Text icon which is a Breeze-ified version of the original icon.
Details
- Reviewers
ndavis ngraham - Group Reviewers
VDG - Commits
- R266:00f1e93bcfdf: Create new Sublime Text icon
Screenshots of my Latte Dock with active Breeze Icon theme:
Before:
After renaming sublime.svg to sublime-text.svg the correct Breeze icon is used:
Diff Detail
- Repository
- R266 Breeze Icons
- Branch
- fix-sublime
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 4831 Build 4849: arc lint + arc unit
I got an error when I tried to land this patch:
remote: Audit failure - Commit 5fa9283264f511edf5678cfd09185a16296c7e71 - Non-full name: Rafael
I know it might seem silly, but please change your name to a full name so that your patch can pass the audit.
I know this is a bugfix, but...
IMHO it's really bad form to design a Breeze version of an app icon that has a totally different visual style from the original--especially if it completely eliminates all the branding elements from the original. This icon should be a Breezey version of the original icon, not something totally different that erases the Sublime Text brand. This is obviously not your fault, but I'd like to see the icon improved before we fix this bug, or else IMHO it will actually be a visual regression for Sublime Text users.
Really, the original mostly looks fine. A Breeze version should just harmonize the size with other square icons, reduce or eliminate the rounded corners, and maybe make some other very subtle changes. If we want to keep the parts of the current icon that depict a tabbed view, we could replace the lines of text with the orange S logo, or overlay it on top of them or something. I'm not sure if the tabbed view iconography is even necessary though.
All of this could be done in the same patch if you have icon design skills and want to tackle that, or in a separate one if not.
Oh, and thanks for the patch, and thanks for using arc to submit it! :)
I'm guessing it was meant to make the Sublime Text icon look similar in style to the Kate and KWrite icons, but you're probably right that using an icon completely different from the official one isn't a good idea.
Original Sublime Text 3 Icon:
I have made a proper Breeze version of the Sublime icon.
It has the slightly rounded edges and the light and dark bars of the Konsole and VLC Icons at the top and bottom.
I have also made one with a border in order to preserve the Elevation of the upper part of the symbol in the original:
Even though it's a bit more faithful to the original, I think it looks worse and doesn't really fit the Breeze style.
Brilliant, I love it! Looks fantastic. Feel free to update this patch to use that new icon. If you want to preserve the elevation of the top part of the S, you could use the same trick as in the original and just render it in a slightly different shade of orange.
- Replaced old Sublime Text icon with a Breeze version of the original logo
Removed invisible alignment rectangle from the SVGs.
I added a shadow to preserve the elevation in the symbol from the original logo:
This is what it looks like in my dock: