D-Bus global hotkey for scanner preview
ClosedPublic

Authored by trufanov on Nov 10 2018, 10:26 PM.

Details

Summary

This is a simple change to allow user to launch Skanlite's scanner preview with D-Bus global hotkey (via KHotkeys app in particular).
This functionality depends on KSane patch: https://phabricator.kde.org/D16795

Note: the new slot is connected in "modern" way which checks slot's existence at compile time and throws an error if it's not found. It may be changed to old-fashion one to make sure new Skanlite builds without error with old libKF5Sane.so (the error message will be printed to stderr at runtime in this case).

Diff Detail

Repository
R483 Skanlite
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
trufanov requested review of this revision.Nov 10 2018, 10:26 PM
trufanov created this revision.
sars accepted this revision.Nov 10 2018, 10:51 PM

The new connections are better because you get an error just for these problems. Explicitly failing is better than silently doing so on run-time.

We need to bump the minor version of libksane and increase the required minimum version of libksane and we are done.

This revision is now accepted and ready to land.Nov 10 2018, 10:51 PM
This revision was automatically updated to reflect the committed changes.