Differential D16811

Load KDE QtQuickSettings in Discover
ClosedPublic
Actions

Authored by davidedmundson on Nov 10 2018, 9:30 PM.

Details

Reviewers
apol
Group Reviewers
Plasma
Commits
R134:d783ebd003c9: Load KDE QtQuickSettings in Discover
Summary

As per other QtQuick parts of Plasma

CCBUG: 400908

Test Plan

Compiles. Code is copy pasted from working projects.

Diff Detail

Repository
R134 Discover Software Store
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 4809
Build 4827: arc lint + arc unit
davidedmundson created this revision.Nov 10 2018, 9:30 PM
Restricted Application added a project: Plasma. · View Herald TranscriptNov 10 2018, 9:30 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson requested review of this revision.Nov 10 2018, 9:30 PM
apol accepted this revision.Nov 12 2018, 12:38 AM
apol added a subscriber: apol.

I wonder if this would make sense in Kirigami integration instead?

This revision is now accepted and ready to land.Nov 12 2018, 12:38 AM
Closed by commit R134:d783ebd003c9: Load KDE QtQuickSettings in Discover (authored by davidedmundson). · Explain WhyNov 12 2018, 11:21 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (2 lines)
Mdiscover/CMakeLists.txt (1 line)
Mdiscover/main.cpp (2 lines)

Diff 45250

View Options

CMakeLists.txt

Loading...
View Options

discover/CMakeLists.txt

Loading...
View Options

discover/main.cpp

Loading...