Update breeze-light and breeze-dark colorschemes
ClosedPublic

Authored by ndavis on Nov 10 2018, 7:08 PM.

Details

Summary

The current colorschemes included in the breeze-light and breeze-dark Plasma themes do not match the Breeze and BreezeDark colorschemes in the breeze repo. For instance, the breeze-dark Plasma theme used an ugly yellow-green for ForegroundNeutral instead of Beware Orange like in the Breeze and BreezeDark colorschemes. It also used a much harsher red that looked inconsistent with BreezeDark. I've been using the new colorschemes for the past month and the most noticeable changes are just the new orange and red colors.

Test Plan

Old:





New:



Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ndavis created this revision.Nov 10 2018, 7:08 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptNov 10 2018, 7:08 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
ndavis requested review of this revision.Nov 10 2018, 7:08 PM
ndavis edited the summary of this revision. (Show Details)Nov 10 2018, 7:09 PM
ndavis edited the test plan for this revision. (Show Details)Nov 10 2018, 7:14 PM
ndavis added reviewers: Breeze, Plasma.
ndavis added projects: VDG, Breeze, Plasma.
ndavis added a subscriber: VDG.
ndavis edited the test plan for this revision. (Show Details)Nov 10 2018, 7:27 PM
ndavis edited the test plan for this revision. (Show Details)
ndavis edited the summary of this revision. (Show Details)Nov 10 2018, 7:36 PM
ndavis edited the summary of this revision. (Show Details)Nov 10 2018, 7:48 PM
ndavis edited the summary of this revision. (Show Details)
ndavis edited the test plan for this revision. (Show Details)Nov 10 2018, 8:06 PM

Should I wait for more people to approve before landing this?

mart accepted this revision.Nov 12 2018, 2:04 PM
This revision is now accepted and ready to land.Nov 12 2018, 2:04 PM
ngraham accepted this revision.Nov 12 2018, 2:12 PM
ngraham added a subscriber: ngraham.

Just tried it out and it's good for me too. Since Plasma folks approve, I say ship it!

This revision was automatically updated to reflect the committed changes.
dcahal added a subscriber: dcahal.Nov 12 2018, 4:50 PM

Great work! That yellow color always looked a bit off, especially in Breeze Light.

That said, the modified orange in Breeze Dark uses an orange color much darker than its blue counterpart. This gives the orange an almost red appearance, reducing its contrast with the blue. It also makes the dark orange less useful as an attention status.

I took the same orange hue used by @ndavis but raised its lightness value to be about 7% lower than the blue. This makes the new Breeze Dark's lightness levels consistent with a pattern established by both this diff's own Breeze Light and the existing Breeze themes.

Please take this into consideration before pushing the new colors. I can probably punch the correct color values into the diff myself if someone can explain to me what the contrast value does.

ndavis added a comment.EditedNov 12 2018, 4:58 PM
In D16810#358475, @davidc wrote:

Great work! That yellow color always looked a bit off, especially in Breeze Light.

That said, the modified orange in Breeze Dark uses an orange color much darker than its blue counterpart. This gives the orange an almost red appearance, reducing its contrast with the blue. It also makes the dark orange less useful as an attention status.

I took the same orange hue used by @ndavis but raised its lightness value to be about 7% lower than the blue. This makes the new Breeze Dark's lightness levels consistent with a pattern established by both this diff's own Breeze Light and the existing Breeze themes.

Please take this into consideration before pushing the new colors. I can probably punch the correct color values into the diff myself if someone can explain to me what the contrast value does.

The issue with making the colors of the Plasma themes different from the normal colorschemes is that it also changes the colors of icons used by those themes. This means that icons won't necessarily look the way they were designed to look. For reference, can you also show what the new orange color looks like on the firewall-applet-panic icon?

Also, this is what the Beware Orange color used by BreezeDark looks like as a task manager alert color in practice:

As far as I could tell this diff was only about improving consistency, not introducing any design changes. If the orange color in Breeze Dark is too dark, it should be changed everywhere all at once, after some discussion. :)