improve variable name for global menu model
AbandonedPublic

Authored by mvourlakos on Nov 10 2018, 2:53 PM.

Details

Reviewers
broulik
davidedmundson
Group Reviewers
Plasma
Summary

--the currentWindowId variable is currently used
only for windows that are delaying their global
menus creation. This patch improves its naming
in order to be able to use the m_currentWindowId
variable in the future for what the name says,
the window id of the current window
independent of its use.

Test Plan

--Test that global menu still works correctly

Diff Detail

Repository
R120 Plasma Workspace
Branch
appMenuDelayed
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 4801
Build 4819: arc lint + arc unit
mvourlakos created this revision.Nov 10 2018, 2:53 PM
Restricted Application added a project: Plasma. · View Herald TranscriptNov 10 2018, 2:53 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mvourlakos requested review of this revision.Nov 10 2018, 2:53 PM

I have sent some patches for Global Menu applet because I want to be clear for the changes that they introduce they should be read in the following order:

  1. D16805 - rename a variable
  2. D16715 - make global menu minimized state aware
  3. D16768 - make global menu screen aware
mvourlakos abandoned this revision.Nov 22 2018, 6:43 PM

included in D16768