Differential D16801

Fix build on macOS
AbandonedPublic
Actions

Authored by harald on Nov 10 2018, 12:29 PM.

Details

Reviewers
None
Summary

On macOS, I'm getting the following error:

CMake Error at src/runtime/plugins/CMakeLists.txt:1 (if):
  if given arguments:

    "AND" "AND"

  Unknown arguments specified

The reason is the double expansion of arguments in CMake, so instead of if (${FOO}) one should write if(FOO).

This patch fixes the build.

Test Plan

Running cmake on Mac OS X passes.

Diff Detail

Repository
R268 KGlobalAccel
Lint
Lint Skipped
Unit
Unit Tests Skipped
harald created this revision.Nov 10 2018, 12:29 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptNov 10 2018, 12:29 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
harald requested review of this revision.Nov 10 2018, 12:29 PM
apol accepted this revision.Nov 12 2018, 12:33 AM
This revision is now accepted and ready to land.Nov 12 2018, 12:33 AM
harald removed a reviewer: apol.Nov 13 2018, 1:31 PM
This revision now requires review to proceed.Nov 13 2018, 1:31 PM
harald abandoned this revision.Nov 13 2018, 2:15 PM

Abandoned, already fixed by https://phabricator.kde.org/D16862

Revision Contents
Changeset List

PathPackages
Msrc/runtime/plugins/CMakeLists.txt (2 lines)

Diff 45229

View Options

src/runtime/plugins/CMakeLists.txt

Loading...