Fix installation instructions format in the README.md for audex
ClosedPublic

Authored by bcornec on Nov 10 2018, 2:10 AM.

Details

Summary

Fix installation instructions format in the README.md for audex by using adequate markdown commands

Diff Detail

Repository
R493 Audex
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bcornec requested review of this revision.Nov 10 2018, 2:10 AM
bcornec created this revision.

Sorry, not sure why i've been added as reviewer to this?

Bare with me, this is my first proposal of patch to KDE, so I'm still struggling to understand how all that is working. I found names of potential reviewers (which seems needed) linked to the audex project, so I thought I should ask them. If that's not the way to do it sorry. I was disappointed that github pull request were not working as for such a small thing, it would be way easier, butthat's the way it is, so trying to understand...

bcooksley accepted this revision.Nov 12 2018, 10:03 AM
bcooksley added subscribers: lesliezhai, steinhauser.

No worries - yeah, we don't use Github requests for this sort of thing at the moment. Alas, it looks like Audex doesn't have a maintainer currently - with the last major work going in in 2016. Adding the last two people to commit in any major fashion to Audex to see if they have any comments to make in relation to this.

The patch itself looks fine though - i'll give it a few days for anyone to file any objections before landing it. If nobody objects in 48 hours time please let me know and i'll go ahead and land this.

This revision is now accepted and ready to land.Nov 12 2018, 10:03 AM

The patch requires IMHO a more descriptive commit message. This is not a generic pull request, but a specific change in a file.

bcornec retitled this revision from Pull request for audex to Fix installation instructions format in the README.md for audex.Nov 18 2018, 3:01 PM
bcornec edited the summary of this revision. (Show Details)
ltoscano accepted this revision.Nov 18 2018, 4:24 PM

Thank you. I guess that you don't have a commit account, right? The patch was sent without using arcanist, which means that it does not have the information about the committer. So either @bcooksley retrieves them and amend the patch to use them, or you provide your email address here and I can do it.

No, I don't have a commit account, as this is just my first ever submission for KDE. I guess that without it I can't use arcanist. Should I have one, create one ?
In any case, my e-mail is bruno@victoria.frmug.org

TIA.

Anyone can use arcanist:
https://community.kde.org/Get_Involved/development#Submit_your_patch

Anyway, not needed anymore for this patch, I can use your email.

This revision was automatically updated to reflect the committed changes.