Differential D16791

[drm] On update always emit screensQueried
AbandonedPublic
Actions

Authored by romangg on Nov 9 2018, 9:35 PM.

Details

Reviewers
davidedmundson
Group Reviewers
KWin
Maniphest Tasks
T10016: Improve Wayland zero output handling
Summary

The screensQueried signal must be emitted also when the output list is empty.
Otherwise the screen count is not cleared and we might seg fault on the next
paint cycle.

Test Plan

Resolves a seg fault for me on one of my systems.

Diff Detail

Repository
R108 KWin
Branch
queryZeroOutputs
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 4784
Build 4802: arc lint + arc unit
romangg created this revision.Nov 9 2018, 9:35 PM
Restricted Application added a project: KWin. · View Herald TranscriptNov 9 2018, 9:35 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
romangg requested review of this revision.Nov 9 2018, 9:35 PM
davidedmundson accepted this revision.Nov 10 2018, 12:43 AM
This revision is now accepted and ready to land.Nov 10 2018, 12:43 AM
romangg abandoned this revision.Feb 19 2019, 1:18 PM

The problem is not so easy to solve I believe now and needs a more holistic approach. Let's go back to the drawing board.

Revision Contents
Changeset List

Diff 45205

View Options

plugins/platforms/drm/drm_backend.cpp

Loading...