Differential D16789

Abstract OutputDevice initialization
ClosedPublic
Actions

Authored by romangg on Nov 9 2018, 8:18 PM.

Details

Reviewers
davidedmundson
Group Reviewers
KWin
Maniphest Tasks
T10016: Improve Wayland zero output handling
Commits
R108:32a9a618894d: Abstract OutputDevice initialization
Summary

Move generic Wayland parts of OutputDevice initialization into
AbstractOutput class.

Diff Detail

Repository
R108 KWin
Branch
abstractOutputDeviceInit
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 4780
Build 4798: arc lint + arc unit
romangg created this revision.Nov 9 2018, 8:18 PM
Restricted Application added a project: KWin. · View Herald TranscriptNov 9 2018, 8:18 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
romangg requested review of this revision.Nov 9 2018, 8:18 PM
davidedmundson accepted this revision.Nov 13 2018, 2:17 PM
davidedmundson added a subscriber: davidedmundson.

I'm not loving the name, the goal of this patchset is to move all of the wayland logic out of the platform.

initWaylandOutput/initXdgOutput are now handled in setEnabled so can be private to AbstractOutput.
We should aim for the same with outputdevice.

I'd rather this was just "AbstractOutput::init()"

Code otherwise is fine

This revision is now accepted and ready to land.Nov 13 2018, 2:17 PM
romangg added a comment.Nov 13 2018, 2:19 PM
In D16789#358969, @davidedmundson wrote:

I'm not loving the name, the goal of this patchset is to move all of the wayland logic out of the platform.

initWaylandOutput/initXdgOutput are now handled in setEnabled so can be private to AbstractOutput.
We should aim for the same with outputdevice.

I'd rather this was just "AbstractOutput::init()"

Code otherwise is fine

Yea, makes sense. I'll take another look at it after this patch series has landed.

Closed by commit R108:32a9a618894d: Abstract OutputDevice initialization (authored by romangg). · Explain WhyNov 14 2018, 6:59 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 45201

View Options

abstract_output.h

Loading...
View Options

abstract_output.cpp

Loading...
View Options

plugins/platforms/drm/drm_output.cpp

Loading...