Abstract output dpms handling
ClosedPublic

Authored by romangg on Nov 9 2018, 7:43 PM.

Details

Summary

Move init and Wayland side changes of dpms modes into
AbstractOutput.

Diff Detail

Repository
R108 KWin
Branch
abstractDpms
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 4865
Build 4883: arc lint + arc unit
romangg created this revision.Nov 9 2018, 7:43 PM
Restricted Application added a project: KWin. · View Herald TranscriptNov 9 2018, 7:43 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
romangg requested review of this revision.Nov 9 2018, 7:43 PM
romangg updated this revision to Diff 45204.Nov 9 2018, 8:35 PM
  • Remove setDpms from header
davidedmundson added inline comments.
abstract_output.cpp
195

This should be a virtual into the platform.

plugins/platforms/drm/drm_output.cpp
189

I think this needs to become a virtual on AbstractOutput, it'll tidy a lot

plugins/platforms/drm/drm_output.cpp
189

Heh. It is in a future patch.

romangg updated this revision to Diff 45349.Nov 12 2018, 10:52 AM
romangg marked an inline comment as done.
  • Add dpmsSupported variable to initWaylandOutput
romangg marked 2 inline comments as done.Nov 12 2018, 10:53 AM
romangg added inline comments.
abstract_output.cpp
195

Good catch! I opted for a simple variable for now.

davidedmundson added inline comments.Nov 12 2018, 2:10 PM
abstract_output.cpp
195

That isn't going to work, at some point you move initWaylandOutput into being done AbstractOutput::setEnabled.

Also the patch seems messed up you set the mode twice?

romangg added inline comments.Nov 12 2018, 2:34 PM
abstract_output.cpp
195

Hmm, true.

Where do I set the mode a second time?

davidedmundson added inline comments.Nov 12 2018, 2:41 PM
abstract_output.cpp
195

You don't, ignore that last bit

romangg updated this revision to Diff 45359.Nov 12 2018, 3:00 PM
  • Use setDpmsSupported setter instead of variable
romangg marked 4 inline comments as done.Nov 12 2018, 3:01 PM
davidedmundson accepted this revision.Nov 12 2018, 3:02 PM
This revision is now accepted and ready to land.Nov 12 2018, 3:02 PM
This revision was automatically updated to reflect the committed changes.