Initialize Wayland output in AbstractOutput
ClosedPublic

Authored by romangg on Nov 9 2018, 6:19 PM.

Details

Summary

Wayland output is on protocol level and not dependent on the hardware
platform. Next steps are to do the same for output device and then let
the virtual output call into these initializing functions as well.

Test Plan

Manually and auto test.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
romangg created this revision.Nov 9 2018, 6:19 PM
Restricted Application added a project: KWin. · View Herald TranscriptNov 9 2018, 6:19 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
romangg requested review of this revision.Nov 9 2018, 6:19 PM

Note, that there are still some properties in DrmOutput for which we still need initDrmWaylandOutput. Hopefully goes away in a few patches though.

davidedmundson accepted this revision.Nov 9 2018, 6:38 PM
davidedmundson added a subscriber: davidedmundson.

Note, that there are still some properties in DrmOutput for which we still need initDrmWaylandOutput. Hopefully goes away in a few patches though.

Ack, it's in a bit of a messy state. But no worse than the current one.

abstract_output.cpp
135

this does nothing, I think setWaylandOutput can be killed completely

141

2 newlines

This revision is now accepted and ready to land.Nov 9 2018, 6:38 PM
romangg marked 2 inline comments as done.Nov 9 2018, 6:47 PM
This revision was automatically updated to reflect the committed changes.