Override code completion will only add the override specifier if the parser
settings don't have either -std=c++03 or 98.
Supersedes: D4039
BUG: 372280
Details
Details
Run test_codecompletion testOverrideExecute
Diff Detail
Diff Detail
- Repository
- R32 KDevelop
- Branch
- config-override
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 4749 Build 4767: arc lint + arc unit
Comment Actions
LGTM in general. If you prefer your version (instead of the one proposed by me) feel free to push directly.
| plugins/clang/codecompletion/context.cpp | ||
|---|---|---|
| 186 | The correct way to capture this would probably be -std=c\+\+(\w+), to also capture potential things like "-std=c++1x" (though you don't check that here). Still feels cleaner. | |
| 191 | And consecutively here: (standard != "98" && standard != "03") Was a little confused by the 3 here at first. I think the string version makes it clearer. | |
| plugins/clang/tests/test_codecompletion.cpp | ||
| 1479 | Unrelated. | |