--a new screenGeometry property is added in the
AppMenuModel in order to be used for filtering
windows based on their geometry.
BUG: 384895, 395853
broulik | |
davidedmundson |
Plasma |
--a new screenGeometry property is added in the
AppMenuModel in order to be used for filtering
windows based on their geometry.
BUG: 384895, 395853
--validate that when moving a window between different screens the global menu applet is updated accordingly
--checkout that nothing has broke because of this new behavior
Automatic diff as part of commit; lint not applicable. |
Automatic diff as part of commit; unit tests not applicable. |
applets/appmenu/plugin/appmenumodel.cpp | ||
---|---|---|
229 | this patch depends on https://phabricator.kde.org/D16715 that has moved it... The m_currentWindowId needs to be set only for windows that create correctly their menus. | |
263 | you mean? setMenuHidden(info.isMinimized() || m_screenGeometry.isNull() || !m_screenGeometry.contains(info.geometry().center())); |
applets/appmenu/plugin/appmenumodel.cpp | ||
---|---|---|
263 | I mean const bool contained = m_screenGeometry.isNull() || m_screenGeometry.contains(info.geometry().center()) setMenuHidden(info.isMinimized() || !contained) |
@davidedmundson I cant commit yet because @mart suggested to rename "menuHidden" to "visible" at https://phabricator.kde.org/D16715
what do you think is the best way to proceed?
I would prefer to accept first D16715 and after that I will rebase this one...