Differential D16762

Build KF5IdleTimeKWinWaylandPrivatePlugin in correct directory
ClosedPublic
Actions

Authored by graesslin on Nov 8 2018, 8:55 PM.

Details

Reviewers
zzag
Group Reviewers
KWin
Commits
R108:c003db22c658: Build KF5IdleTimeKWinWaylandPrivatePlugin in correct directory
Summary

Ensures that we can load the plugin when running only from build dir.

Diff Detail

Repository
R108 KWin
Branch
idletime-build-dir
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 4728
Build 4746: arc lint + arc unit
graesslin created this revision.Nov 8 2018, 8:55 PM
Restricted Application added a project: KWin. · View Herald TranscriptNov 8 2018, 8:55 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
graesslin requested review of this revision.Nov 8 2018, 8:55 PM
zzag added a subscriber: zzag.Nov 9 2018, 11:16 AM

Noob question: do we use KIdleTime in KWin?

graesslin added a comment.Nov 9 2018, 12:31 PM
In D16762#356687, @zzag wrote:

Noob question: do we use KIdleTime in KWin?

Indirectly. On Wayland KWin provides the lock screen and the lock screen activates based on KIdleTime. The plugin we have here is to make it work through KWin's own existing internal Wayland connection. The generic Wayland plugin would dead-lock inside KWin.

zzag accepted this revision.Nov 9 2018, 12:34 PM
This revision is now accepted and ready to land.Nov 9 2018, 12:35 PM
Closed by commit R108:c003db22c658: Build KF5IdleTimeKWinWaylandPrivatePlugin in correct directory (authored by graesslin). · Explain WhyNov 9 2018, 4:39 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mplugins/idletime/CMakeLists.txt (1 line)

Diff 45130

View Options

plugins/idletime/CMakeLists.txt

Loading...