Custom build/source directories
ClosedPublic

Authored by janpr on Nov 8 2018, 5:02 PM.

Details

Summary

My changes let the user choose custom build and source directories. There already was the option to choose a custom install directory, I see no reason why this shouldn't be possible for the build and source directories.

Diff Detail

Repository
R365 kdesrc-build
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
janpr requested review of this revision.Nov 8 2018, 5:02 PM
janpr created this revision.
janpr retitled this revision from ===Custom build/source directories=== My changes let the user choose custom build and source directories. There already was the option to choose a custom install directory, I see no reason why this shouldn't be possible for the build and source... to Custom build/source directories.Nov 8 2018, 5:03 PM
janpr edited the summary of this revision. (Show Details)
mpyne added a comment.Nov 17 2018, 5:21 PM

Not asking about source-dir/build-dir (but mentioning them in the resulting file) was deliberate, as a way of reducing the number of options that must be completed to go from nothing to a working configuration.

I'm not opposed to asking for these install locations, especially since there's a "first-run" feature coming to allow for non-interactive setup. I think the wording on the questions can be more clear though.

e.g. "Where should source codes be saved?" instead of "Where do you want to source the software?". The current build dir question is already more clear but even for that I'd rather have something like "Where should temporary build products be saved (needs lots of space)?" I think.

One other change I'd request is to ask about source directory first, then build directory. That's the same order used pretty much everywhere else if both are present and I want to maintain that consistency.

Are you able to commit yourself or do you need me to commit?

janpr updated this revision to Diff 45694.EditedNov 17 2018, 8:51 PM

Thanks for your feedback, I made the requested changes:

  • Questions are worded more clearly
  • Ask for the source directory first

An additional change that wasn't requested:
When the user chooses custom directories, the defaults are now different for every directory.

I am not able to commit myself.

mpyne accepted this revision.Nov 18 2018, 8:59 PM

OK, I've already committed (commit 86989e34ccc81c9695c8e638ea8fee1b6343d267) but if our git servers don't close this review request it should be OK for you to close this.

This revision is now accepted and ready to land.Nov 18 2018, 8:59 PM
This revision was automatically updated to reflect the committed changes.