[autotests] Fix maximize test
ClosedPublic
Actions

Authored by zzag on Nov 8 2018, 11:26 AM.

Details

Reviewers

davidedmundson

Group Reviewers

KWin

Commits

R108:abf6c6927cbf: [autotests] Fix maximize test

Summary

testMaximizedPassedToDeco was failing because it didn't handle async
maximization.

testBorderlessMaximizedWindow was failing because setNoBorder can modify
geometry, so we end up with a wrong restore geometry.

Repository

R108 KWin

Branch

fix-test-maximize

Lint

Lint OK

Unit

No Unit Test Coverage

Build Status

Buildable 4716
Build 4734: arc lint + arc unit

Restricted Application added a project: KWin. · View Herald TranscriptNov 8 2018, 11:26 AM

Restricted Application added a subscriber: kwin. · View Herald Transcript

zzag requested review of this revision.Nov 8 2018, 11:26 AM

thanks

This revision is now accepted and ready to land.Nov 8 2018, 12:09 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			autotests/integration/maximize_test.cpp (16 lines)
M			shell_client.cpp (6 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	45111	80d0915		Nov 8 2018, 11:26 AM	★	★
Diff 2	45114	80d0915	R108:abf6c6927cbf9a156c8a95ce33bbb40651a42008	Nov 8 2018, 12:10 PM	★	★