Differential D16743

[libkwineffects] Use correct type for the desktops property
ClosedPublic
Actions

Authored by zzag on Nov 7 2018, 6:47 PM.

Details

Reviewers
graesslin
Group Reviewers
KWin
Commits
R108:f4663072774e: [libkwineffects] Use correct type for the desktops property
Summary

Type of the x11DesktopIds property was changed from QList<int> to
QVector<int> in KWin core, but not in libkwineffects. That resulted in
having effects like slide not working because Qt can't implicitly
convert QVector<int> to QList<int>.

Test Plan

Slide effect works again.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zzag created this revision.Nov 7 2018, 6:47 PM
Restricted Application added a project: KWin. · View Herald TranscriptNov 7 2018, 6:47 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Nov 7 2018, 6:47 PM
zzag edited the summary of this revision. (Show Details)Nov 7 2018, 6:50 PM
zzag updated this revision to Diff 45065.Nov 7 2018, 7:04 PM

Use WINDOW_HELPER macro

graesslin accepted this revision.Nov 7 2018, 7:06 PM
This revision is now accepted and ready to land.Nov 7 2018, 7:06 PM
Closed by commit R108:f4663072774e: [libkwineffects] Use correct type for the desktops property (authored by zzag). · Explain WhyNov 7 2018, 7:06 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 45066

View Options

libkwineffects/kwineffects.h

Loading...
View Options

libkwineffects/kwineffects.cpp

Loading...