Remove potential endless loop from XClipboardSyncTest
ClosedPublic

Authored by graesslin on Nov 7 2018, 4:47 PM.

Details

Summary

We need to wait till the helper process created the datadevice. For this
we used a while loop. On build.kde.org the test gets stuck in this loop
and times out after 10 minutes.

This change introduces a dedicated signal and we just wait for it. So if
something fails we wait only 5 sec instead of endless. This should help
investigate why the test doesn't work on build.kde.org.

Test Plan

Test works locally

Diff Detail

Repository
R108 KWin
Branch
xclipboard-sync-no-endless-loop
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 4685
Build 4703: arc lint + arc unit
graesslin created this revision.Nov 7 2018, 4:47 PM
Restricted Application added a project: KWin. · View Herald TranscriptNov 7 2018, 4:47 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
graesslin requested review of this revision.Nov 7 2018, 4:47 PM
zzag accepted this revision.Nov 7 2018, 5:17 PM
This revision is now accepted and ready to land.Nov 7 2018, 5:17 PM
This revision was automatically updated to reflect the committed changes.