Differential D16741

Remove potential endless loop from XClipboardSyncTest
ClosedPublic
Actions

Authored by graesslin on Nov 7 2018, 4:47 PM.

Details

Reviewers
zzag
Group Reviewers
KWin
Commits
R108:e637d432111f: Remove potential endless loop from XClipboardSyncTest
Summary

We need to wait till the helper process created the datadevice. For this
we used a while loop. On build.kde.org the test gets stuck in this loop
and times out after 10 minutes.

This change introduces a dedicated signal and we just wait for it. So if
something fails we wait only 5 sec instead of endless. This should help
investigate why the test doesn't work on build.kde.org.

Test Plan

Test works locally

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin created this revision.Nov 7 2018, 4:47 PM
Restricted Application added a project: KWin. · View Herald TranscriptNov 7 2018, 4:47 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
graesslin requested review of this revision.Nov 7 2018, 4:47 PM
zzag accepted this revision.Nov 7 2018, 5:17 PM
This revision is now accepted and ready to land.Nov 7 2018, 5:17 PM
Closed by commit R108:e637d432111f: Remove potential endless loop from XClipboardSyncTest (authored by graesslin). · Explain WhyNov 7 2018, 7:12 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 45068

View Options

autotests/integration/xclipboardsync_test.cpp

Loading...
View Options

wayland_server.h

Loading...
View Options

wayland_server.cpp

Loading...