[autotests] Handle async maximisation in quick tiling test
ClosedPublic

Authored by davidedmundson on Nov 7 2018, 4:17 PM.

Details

Summary

KWin now correctly updates the client maximised state when we have a new
buffer in the new state. The quick tile unit test was unfortunately not
updated.

Diff Detail

Repository
R108 KWin
Branch
master
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 4681
Build 4699: arc lint + arc unit
davidedmundson created this revision.Nov 7 2018, 4:17 PM
Restricted Application added a project: KWin. · View Herald TranscriptNov 7 2018, 4:17 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
davidedmundson requested review of this revision.Nov 7 2018, 4:17 PM
zzag added a subscriber: zzag.Nov 7 2018, 4:51 PM
zzag added inline comments.
autotests/integration/quick_tiling_test.cpp
292

Could it stay here?

292

Maybe this is slightly off-topic, but... could we clear the spies here?

graesslin accepted this revision.Nov 7 2018, 5:00 PM
graesslin added a subscriber: graesslin.
graesslin added inline comments.
autotests/integration/quick_tiling_test.cpp
292

could be done. I hardly clear, though. I find it gives some value in the test to see how often the signals are emitted. Especially when having multiple. I found bugs through that.

This revision is now accepted and ready to land.Nov 7 2018, 5:00 PM
davidedmundson added inline comments.Nov 8 2018, 1:50 AM
autotests/integration/quick_tiling_test.cpp
292

It could. Done

292

There's definitely value in checking there are no spurious emits - but you can do that with clears or not. I tend to in any tests I write, but I wouldn't rewrite anything, especially when the count only goes to 2.

This revision was automatically updated to reflect the committed changes.