| KWin | |
| Frameworks |
Adds support for the text_input_unstable_v3 protocol to our current
implementations v0 and v2.
Protocol v3 is relatively new and features large changes relative to v2.
All state changes are now double buffered and key input functionality has been
removed, what makes the protocol leaner.
Autotest amended.
| Lint OK |
| No Unit Test Coverage |
| Buildable 4673 | |
| Build 4691: arc lint + arc unit |
| autotests/client/test_text_input.cpp | ||
|---|---|---|
| 545–548 | Personal opinion: tests have to be easy to follow, it's okay if we copy some code. I'd prefer to have a specialized test, e.g. testSurroundingTextV3. | |
| 1001 | If there is only one row, we don't need _data(). | |
| src/client/textinput.h | ||
| 122 | **/ | |
| src/client/textinput_p.h | ||
| 83 | V3? | |
| src/server/textinput_interface_v3.cpp | ||
| 137–140 | Please use single line comments instead. | |
| 428 | We don't need this namespace because waylandCauseToKWayland is static. | |