Capture package metadata before install start

Authored by davidedmundson on Nov 7 2018, 12:21 PM.



KPackage (despite being supposedly internally shared) is not kept as a
strong reference inside PackageJob. Potentially it could go out of scope
before a job ends.

The signals to emit changes relied on the package. This patch captures
relevant metadata at the start of the install.

noCrashOnAsyncInstall test now passes again

Test Plan

Ran test

Diff Detail

R290 KPackage
No Linters Available
No Unit Test Coverage
Build Status
Buildable 4670
Build 4688: arc lint + arc unit
davidedmundson created this revision.Nov 7 2018, 12:21 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptNov 7 2018, 12:21 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
davidedmundson requested review of this revision.Nov 7 2018, 12:21 PM
apol accepted this revision.Nov 7 2018, 12:44 PM
apol added a subscriber: apol.

I would add a comment saying "please don't call d->package from the lambda because it breaks".

This revision is now accepted and ready to land.Nov 7 2018, 12:44 PM
This revision was automatically updated to reflect the committed changes.