Differential D16733

Capture package metadata before install start
ClosedPublic
Actions

Authored by davidedmundson on Nov 7 2018, 12:21 PM.

Details

Reviewers
apol
Commits
R242:ed1724c63e9f: Summary: After this commit https://cgit.kde.org/plasma-framework.git/commit/?
R242:0813882abc64: Summary: After this commit https://cgit.kde.org/plasma-framework.git/commit/?
R290:451b1785e8d0: Capture package metadata before install start
R290:3eaab0bd8aa9: Capture package metadata before install start
Summary

KPackage (despite being supposedly internally shared) is not kept as a
strong reference inside PackageJob. Potentially it could go out of scope
before a job ends.

The signals to emit changes relied on the package. This patch captures
relevant metadata at the start of the install.

noCrashOnAsyncInstall test now passes again

Test Plan

Ran test

Diff Detail

Repository
R290 KPackage
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Nov 7 2018, 12:21 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptNov 7 2018, 12:21 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
davidedmundson requested review of this revision.Nov 7 2018, 12:21 PM
apol accepted this revision.Nov 7 2018, 12:44 PM
apol added a subscriber: apol.

I would add a comment saying "please don't call d->package from the lambda because it breaks".

This revision is now accepted and ready to land.Nov 7 2018, 12:44 PM
Closed by commit R290:451b1785e8d0: Capture package metadata before install start (authored by davidedmundson). · Explain WhyNov 7 2018, 12:49 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 45028

View Options

src/kpackage/private/packagejob.cpp

Loading...