Differential D16732

Start xclipboard sync process from build dir if available
ClosedPublic
Actions

Authored by graesslin on Nov 7 2018, 11:51 AM.

Details

Reviewers
zzag
Group Reviewers
KWin
Commits
R108:7221864cd24c: Start xclipboard sync process from build dir if available
Summary

The xclipboard sync test times out on build.kde.org as KWin is not
installed prior to running the tests. This is due to KWin not finding
the executable for the clipboard sync helper.

This change looks whether the binary exists in the same directory as
KWin's executable. If it exists it is started instead of the hardcoded
path in libexec.

Test Plan

Run the test and verified the correct binary is loaded

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin created this revision.Nov 7 2018, 11:51 AM
Restricted Application added a project: KWin. · View Herald TranscriptNov 7 2018, 11:51 AM
Restricted Application added a subscriber: kwin. · View Herald Transcript
graesslin requested review of this revision.Nov 7 2018, 11:51 AM
zzag accepted this revision.Nov 7 2018, 12:34 PM
zzag added a subscriber: zzag.

Maybe it would be worth to leave a comment why we search for org_kde_kwin_xclipboard_syncer in the directory that contains kwin's executable.

This revision is now accepted and ready to land.Nov 7 2018, 12:34 PM
Closed by commit R108:7221864cd24c: Start xclipboard sync process from build dir if available (authored by graesslin). · Explain WhyNov 7 2018, 2:20 PM
This revision was automatically updated to reflect the committed changes.
graesslin added a comment.Nov 7 2018, 2:32 PM

Damn, it looks like it's still timing out on build.kde.org

Revision Contents
Changeset List

PathPackages
Mwayland_server.cpp (10 lines)

Diff 45035

View Options

wayland_server.cpp

Loading...