Differential D16724

Condense UI of the Specific color selector
ClosedPublic
Actions

Authored by amedonosova on Nov 7 2018, 7:20 AM.

Details

Reviewers
rempt
Group Reviewers
Krita
Commits
R37:f702304f3cb0: Condense UI of the Specific color selector
Summary

This diff moves selection of color space into a popup, as suggested in
bug 362952. It also changes the 'Use percentage' checkbox to a toggle
button, to further condense the controls.

The layout is now in a designer form.

Adds new SVG icons for 'ratio'.

BUG: 362952

Diff Detail

Repository
R37 Krita
Branch
amedonosova/specific-color-selector
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 4701
Build 4719: arc lint + arc unit
amedonosova created this revision.Nov 7 2018, 7:20 AM
Restricted Application added a reviewer: Krita. · View Herald TranscriptNov 7 2018, 7:20 AM
Restricted Application added a project: Krita. · View Herald Transcript
amedonosova requested review of this revision.Nov 7 2018, 7:20 AM
amedonosova added a subscriber: scottpetrovic.Nov 7 2018, 1:32 PM

From a discussion with @scottpetrovic on the IRC:

  • add suffix to numbers when percentage is on, to show it more clearly
  • change the 'set color space' button to something like a label with the current color space + configuration button
amedonosova updated this revision to Diff 45091.EditedNov 8 2018, 7:15 AM
  • spec.color.sel: add colorspace name as button label

amedonosova updated this revision to Diff 45123.Nov 8 2018, 5:36 PM
  • unit suffix for KisIntegerColorInput
  • right-align Kis*ColorInput/Kis*ParseSpinbox
amedonosova updated this revision to Diff 45248.Nov 10 2018, 8:02 PM
  • spec.color.sel: UI cleanup
rempt accepted this revision.Nov 11 2018, 1:46 PM
rempt added a subscriber: rempt.

Looks very good now!

This revision is now accepted and ready to land.Nov 11 2018, 1:46 PM
Closed by commit R37:f702304f3cb0: Condense UI of the Specific color selector (authored by amedonosova). · Explain WhyNov 11 2018, 4:17 PM
This revision was automatically updated to reflect the committed changes.
scottpetrovic added a comment.Nov 11 2018, 7:43 PM

Great job anna!

Revision Contents
Changeset List

Diff 45091

View Options

krita/pics/svg/dark_ratio.svg

Loading...
View Options

krita/pics/svg/light_ratio.svg

Loading...
View Options

krita/pics/svg/svg-icons.qrc

Loading...
View Options

plugins/dockers/specificcolorselector/CMakeLists.txt

Loading...
View Options

plugins/dockers/specificcolorselector/kis_specific_color_selector_widget.h

Loading...
View Options

plugins/dockers/specificcolorselector/kis_specific_color_selector_widget.cc

Loading...
View Options

plugins/dockers/specificcolorselector/wdgSpecificColorSelectorWidget.ui

Loading...