[wayland] add explict AbstractClient::setDesktops(QList)
ClosedPublic

Authored by davidedmundson on Nov 6 2018, 12:00 PM.

Details

Summary

Currently setDesktop and unsetDesktop were out of sync, with the latter
missing several important signals and updating of transients.

By using a a shared implementation we avoid that, it also allows for an
atomic move of a window between desktops.

setDesktop is changed back to be a moval of desktop as it currently
broke several unit tests as well as changing the behaviour of the move
to desktop shortcut on wayland.

Test Plan

testBindings now passes
Moved windows with the context menu on X11

Diff Detail

Repository
R108 KWin
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 4623
Build 4641: arc lint + arc unit
davidedmundson created this revision.Nov 6 2018, 12:00 PM
Restricted Application added a project: KWin. · View Herald TranscriptNov 6 2018, 12:00 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
davidedmundson requested review of this revision.Nov 6 2018, 12:00 PM
graesslin added inline comments.
abstract_client.h
1107

Please don't use QList anymore

rebase with vectors

somehow I think phab is showing the wrong diff now

graesslin accepted this revision.Nov 7 2018, 4:57 PM
graesslin added inline comments.
abstract_client.cpp
504

you can simplify this to: {desktops.first()}

This revision is now accepted and ready to land.Nov 7 2018, 4:57 PM
This revision was automatically updated to reflect the committed changes.