SessionManager: Close all split views before session restore
ClosedPublic

Authored by loh.tar on Nov 5 2018, 4:43 PM.

Details

Summary

They are not properly handled and cause various trouble up to a
complete missing view

Test Plan
  • Create & save a session with three horizontal splits
  • Switch to an other session with no split view

Looks good or bad? In my case was the view completely gone, only the plugins to see

  • Switch back to the first session

Looks also bad, not again three splitter

This patch is more a workaround than a solution of the core problem which should reside in KateViewManager::restoreSplitter, but I noticed that too late to dig into it, current solution works here good enough :-)

Diff Detail

Repository
R40 Kate
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
loh.tar created this revision.Nov 5 2018, 4:43 PM
Restricted Application added a subscriber: kwrite-devel. · View Herald TranscriptNov 5 2018, 4:43 PM
loh.tar requested review of this revision.Nov 5 2018, 4:43 PM

Hmm, you are right, that is somehow broken.
I will try to cleanup the splitters properly in KateViewManager::restoreViewConfiguration(const KConfigGroup &config).

This revision was not accepted when it landed; it landed in state Needs Review.Nov 11 2018, 2:36 PM
This revision was automatically updated to reflect the committed changes.

For me this small patch seems to work, too, and should handle all cases we call this function (if we ever call it in other places that has an already existing window)