Differential D16680

Build ABIs for all libraries even one is failing.
ClosedPublic
Actions

Authored by knauss on Nov 5 2018, 12:31 PM.

Details

Reviewers
bcooksley
Maniphest Tasks
T3689: Add abi compliance checker to CI
Commits
R857:1fd953bcd4f5: Build ABIs for all libraries even if one or more are failing. This allows for…
Summary

A repository may contain multiple libraries. Failing with the first
error creating an ABI dump is not the a good default. A better approch
is to try to build ABIs for all libraries and display the failures.

Diff Detail

Repository
R857 CI System Tooling
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
knauss requested review of this revision.Nov 5 2018, 12:31 PM
knauss created this revision.
bcooksley accepted this revision.Nov 5 2018, 5:33 PM

Looks good to me.

This revision is now accepted and ready to land.Nov 5 2018, 5:33 PM
knauss updated this revision to Diff 45253.Nov 10 2018, 10:11 PM

update environment.

@bcooksley: ping - you accepted it alrey, why it is not merged?

bcooksley added a comment.Nov 11 2018, 6:24 AM

Sorry, looks like this got lost and didn't end up getting applied.

As we've had a few other changes land since then it unfortunately no longer applies - could you rebase this please?

knauss updated this revision to Diff 45263.Nov 11 2018, 8:08 AM

rebase.

Closed by commit R857:1fd953bcd4f5: Build ABIs for all libraries even if one or more are failing. This allows for… (authored by knauss, committed by bcooksley). · Explain WhyNov 11 2018, 9:43 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhelpers/create-abi-dump.py (49 lines)

Diff 45269

View Options

helpers/create-abi-dump.py

Loading...