[app] Add system volume control
ClosedPublic

Authored by nicolasfella on Nov 4 2018, 6:06 PM.

Details

Summary

Add a remote systemvolume plugin.

Test Plan

Change volume via slider -> Volume on target changes
Change volume on target -> Slider changes

Mute via button -> Mute on target changes
Mute on target -> Button changes icon

Add/remove sink on host -> Sink is add/removed in list

Diff Detail

Repository
R224 KDE Connect
Branch
remotesystemvolume
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 4562
Build 4580: arc lint + arc unit
nicolasfella created this revision.Nov 4 2018, 6:06 PM
Restricted Application added a project: KDE Connect. · View Herald TranscriptNov 4 2018, 6:06 PM
Restricted Application added a subscriber: kdeconnect. · View Herald Transcript
nicolasfella requested review of this revision.Nov 4 2018, 6:06 PM
  • Revert test mode change
  • Remove readme
apol added a subscriber: apol.Nov 5 2018, 12:00 AM

Maybe it should only be compiled if EXPERIMENTALAPP_ENABLED?

interfaces/remotesinksmodel.cpp
107

You can clear it as it is resetting, so the view doesn't refresh twice.

  • Clear sinks while resetting
  • Only include when building app
apol accepted this revision.Nov 7 2018, 11:27 PM
This revision is now accepted and ready to land.Nov 7 2018, 11:27 PM
This revision was automatically updated to reflect the committed changes.