Differential D16659

Size according to specified icon width and height
ClosedPublic
Actions

Authored by astippich on Nov 4 2018, 9:55 AM.

Details

Reviewers
mart
apol
Group Reviewers
Plasma
Commits
R858:66d8bdb32735: Size according to specified icon width and height
Summary

The icon.width and icon.height property were
not used before for the icon

Diff Detail

Repository
R858 Qt Quick Controls 2: Desktop Style
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
astippich created this revision.Nov 4 2018, 9:55 AM
Restricted Application added a project: Plasma. · View Herald TranscriptNov 4 2018, 9:55 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
astippich requested review of this revision.Nov 4 2018, 9:55 AM
apol added a comment.Nov 5 2018, 12:22 AM

+1 overall

plugin/kquickstyleitem.cpp
193

Can we be a bit smarter here? If the size is present maybe we wouldn't have to check the pixelMetric.

astippich updated this revision to Diff 44936.Nov 5 2018, 8:42 PM
  • only query pixelMetric on demand
mart accepted this revision.Nov 12 2018, 10:43 AM
This revision is now accepted and ready to land.Nov 12 2018, 10:43 AM
Closed by commit R858:66d8bdb32735: Size according to specified icon width and height (authored by astippich). · Explain WhyNov 13 2018, 4:41 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Morg.kde.desktop/Button.qml (2 lines)
Mplugin/kquickstyleitem.cpp (13 lines)

Diff 45423

View Options

org.kde.desktop/Button.qml

Loading...
View Options

plugin/kquickstyleitem.cpp

Loading...