Differential D16656

Bug 392836 - Adblock uses outdated Spanish filters (Filtros Naucópicos)
ClosedPublic
Actions

Authored by krishremya on Nov 4 2018, 8:29 AM.

Details

Reviewers
drosca
Commits
R875:cda838a35ea2: Adblock uses outdated Spanish filters (Filtros Naucópicos)
Summary

Replaced the link to a filter set with Easylist Spanish, that is changed the outdated Spanish filters into the updated one.
Bug 392836

Diff Detail

Repository
R875 Falkon
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
krishremya created this revision.Nov 4 2018, 8:29 AM
Restricted Application added a project: Falkon. · View Herald TranscriptNov 4 2018, 8:29 AM
Restricted Application added a subscriber: falkon. · View Herald Transcript
krishremya requested review of this revision.Nov 4 2018, 8:29 AM
krishremya edited the summary of this revision. (Show Details)Nov 4 2018, 8:40 AM
drosca requested changes to this revision.Nov 4 2018, 9:10 AM
drosca added a subscriber: drosca.

This will change the default list (EasyList) to be Spanish variant for all users.
You should instead change the url to Spanish subscriptions in AdBlockAddSubscriptionDialog

This revision now requires changes to proceed.Nov 4 2018, 9:10 AM
krishremya updated this revision to Diff 44819.Nov 4 2018, 9:26 AM

Made the changes in AdBlockAddSubscriptionDialog, replaced the old link with the new one, so as to update the Spanish filters.

drosca accepted this revision.Nov 4 2018, 10:25 AM

Looks good now, thanks. If you don't have dev account please send me your full name + email and I will commit it for you.

This revision is now accepted and ready to land.Nov 4 2018, 10:25 AM
krishremya added a comment.Nov 4 2018, 10:55 AM
In D16656#353815, @drosca wrote:

Looks good now, thanks. If you don't have dev account please send me your full name + email and I will commit it for you.

Thanks,
Full Name: Remya Krishnan
email-id: krishremya99@gmail.com

Closed by commit R875:cda838a35ea2: Adblock uses outdated Spanish filters (Filtros Naucópicos) (authored by krishremya, committed by drosca). · Explain WhyNov 4 2018, 3:17 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 44850

View Options

src/lib/adblock/adblockaddsubscriptiondialog.cpp

Loading...