Differential D16654

Remove unused FindQt5PlatformSupport.cmake
ClosedPublic
Actions

Authored by gladhorn on Nov 4 2018, 7:46 AM.

Details

Reviewers
zzag
Group Reviewers
KWin
Commits
R108:503661579fff: Remove unused FindQt5PlatformSupport.cmake
Summary

This file was required for Qt 5.8. We require 5.11 as minimum version.

Test Plan

Grepped for the file being used in other cmake code, rebuilt KWin without it.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
gladhorn created this revision.Nov 4 2018, 7:46 AM
Restricted Application added a project: KWin. · View Herald TranscriptNov 4 2018, 7:46 AM
gladhorn requested review of this revision.Nov 4 2018, 7:46 AM
zzag added a subscriber: zzag.Nov 4 2018, 9:37 AM

Grepped for the file being used in other cmake code, rebuilt KWin without it.

https://phabricator.kde.org/source/kwin/browse/master/plugins/qpa/CMakeLists.txt$22-25

On the other hand, as far as I know, we don't support Qt < 5.8.0 anymore.

zzag edited reviewers, added: KWin; removed: kwin.Nov 4 2018, 9:38 AM
Restricted Application added a subscriber: kwin. · View Herald TranscriptNov 4 2018, 9:38 AM
zzag requested changes to this revision.Nov 4 2018, 9:44 AM
This revision now requires changes to proceed.Nov 4 2018, 9:44 AM
gladhorn added a comment.Nov 4 2018, 12:21 PM

Ouch, I overlooked that, good catch.

gladhorn updated this revision to Diff 44837.Nov 4 2018, 12:25 PM
gladhorn retitled this revision from Remove unused and broken FindQt5PlatformSupport.cmake to Remove unused FindQt5PlatformSupport.cmake.
gladhorn edited the summary of this revision. (Show Details)

Updated to remove more legacy code.

zzag accepted this revision.Nov 4 2018, 12:40 PM
This revision is now accepted and ready to land.Nov 4 2018, 12:40 PM
Closed by commit R108:503661579fff: Remove unused FindQt5PlatformSupport.cmake (authored by gladhorn). · Explain WhyNov 4 2018, 4:01 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 44851

View Options

cmake/modules/FindQt5PlatformSupport.cmake

Loading...
View Options

plugins/qpa/CMakeLists.txt

Loading...