Use the new `drive-harddisk-root` icon for the root volume
ClosedPublic
Actions

Authored by ngraham on Nov 3 2018, 10:26 PM.

Details

Reviewers

romangg
bruns
abetts

Group Reviewers

VDG
Dolphin
Frameworks

Maniphest Tasks

T8349: Improve Places panel usability and presentation

Commits

R245:b34d13cb1861: Use the new `drive-harddisk-root` icon for the root volume

Summary

Use the new drive-harddisk-root icon to mark the root volume. This makes it obvious which disk corresponds to / when there are multiple disks, and allows us to remove the root entry from the top section of the Places panel (D15739)

Depends on D16633

Test Plan

Diff Detail

Repository

R245 Solid

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

ngraham created this revision.Nov 3 2018, 10:26 PM

Restricted Application added a project: Frameworks. · View Herald TranscriptNov 3 2018, 10:26 PM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

ngraham requested review of this revision.Nov 3 2018, 10:26 PM

Harbormaster completed remote builds in B4532: Diff 44808.Nov 3 2018, 10:26 PM

ngraham added a task: T8349: Improve Places panel usability and presentation.Nov 3 2018, 10:27 PM

ngraham edited the summary of this revision. (Show Details)Nov 3 2018, 10:31 PM

ngraham edited the test plan for this revision. (Show Details)

ngraham added a dependent revision: D15739: [Places panel] Don't show Root by default.

ngraham added a reviewer: bruns.Nov 3 2018, 10:33 PM

acrouthamel awarded a token.Nov 3 2018, 10:35 PM

ngraham mentioned this in T8349: Improve Places panel usability and presentation.Nov 3 2018, 10:44 PM

bruns added inline comments.Nov 4 2018, 10:22 PM

src/solid/devices/backends/udisks2/udisksdevice.cpp
619	QLatin1String
620	QStringLiteral

Fix embarrassing errors

Harbormaster completed remote builds in B4568: Diff 44871.Nov 4 2018, 10:27 PM

bruns accepted this revision.Nov 4 2018, 10:28 PM

This revision is now accepted and ready to land.Nov 4 2018, 10:28 PM

Minor detail with great impact. Thank you for the work.

Closed by commit R245:b34d13cb1861: Use the new `drive-harddisk-root` icon for the root volume (authored by ngraham). · Explain WhyNov 4 2018, 10:59 PM

This revision was automatically updated to reflect the committed changes.

This broke icons for other things; currently investigating and will fix ASAP.

ngraham mentioned this in D16678: Fix root disk icon change so that it doesn't erroneously change other icons.Nov 5 2018, 4:46 AM

Hopefully this should fix it: D16678

ngraham mentioned this in R245:6d0f74132fcd: Fix root disk icon change so that it doesn't erroneously change other icons.Nov 5 2018, 11:28 PM

Revision Contents
Changeset List

			Path	Packages
M			src/solid/devices/backends/udisks2/udisksdevice.cpp (5 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	44808	3ac52c2		Nov 3 2018, 10:26 PM	★	★
Diff 2	44871	3ac52c2	Fix embarrassing errors	Nov 4 2018, 10:26 PM	★	★
Diff 3	44875	3ac52c2	R245:b34d13cb186162e1a2d75957de9636ec53b7d79b	Nov 4 2018, 10:59 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
7ca40b141167	ae0d57fa93ed	3ac52c291172	Nate Graham	Use the new `drive-harddisk-root` icon for the root volume (Show More…)	Nov 4 2018, 10:23 PM

Status	Author	Revision
Closed	meven	D7446 [Places panel] Revamp the Recently Saved section
Closed	meven	D22144 Add kio recentlyused:/ to access KActivityStats data
Closed	meven	D23742 Add two special cases url recentlyused:/files and recentlyused:/folders
Closed	meven	D23736 Add Term::Type::files() and Term::Type::directories() to filter only directories or excluding them
Closed	meven	D23737 Extract mimetype from recentlyused.xbel
Closed	meven	D23741 Save the Mimetype of opened resources
Closed	ngraham	D23760 Create new "Recent folders" icon
Closed	meven	D21789 Fix tests relating to the removal of the Root Place in D15739
Closed	meven	D15739 [Places panel] Don't show Root by default
Closed	ngraham	D16653 Use the new `drive-harddisk-root` icon for the root volume
Closed	ndavis	D16633 Add root version of drive-harddisk

Diff 44875

View Options

src/solid/devices/backends/udisks2/udisksdevice.cpp