Differential D16651

Honor flat property of buttons
ClosedPublic
Actions

Authored by astippich on Nov 3 2018, 6:57 PM.

Details

Reviewers
ngraham
mart
apol
Group Reviewers
Plasma
Commits
R858:8c1fb20f52a5: Honor flat property of buttons
Summary

The flat property of buttons is currently not taken into
account for the desktop style. Wire it up.

Diff Detail

Repository
R858 Qt Quick Controls 2: Desktop Style
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
astippich created this revision.Nov 3 2018, 6:57 PM
Restricted Application added a project: Plasma. · View Herald TranscriptNov 3 2018, 6:57 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
astippich requested review of this revision.Nov 3 2018, 6:57 PM
astippich retitled this revision from honor flat property for buttons to Honor flat property of buttons.Nov 4 2018, 9:50 AM
apol added a comment.Nov 5 2018, 12:18 AM

Looks good overall.

Maybe it would make sense to add a test in tests/buttonIcons.qml?

org.kde.desktop/Button.qml
63

No need to check for controlRoot.flat twice

astippich updated this revision to Diff 44934.Nov 5 2018, 7:41 PM
  • do not unnecessarily check flat property
astippich marked an inline comment as done.Nov 5 2018, 7:42 PM

How can I actually run this test?

astippich added a comment.Nov 13 2018, 10:40 AM

friendly ping

mart accepted this revision.Nov 13 2018, 2:01 PM
This revision is now accepted and ready to land.Nov 13 2018, 2:01 PM
Closed by commit R858:8c1fb20f52a5: Honor flat property of buttons (authored by astippich). · Explain WhyNov 13 2018, 4:41 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 45422

View Options

org.kde.desktop/Button.qml

Loading...
View Options

plugin/kquickstyleitem.cpp

Loading...