Add explicit edit mode to device name field
ClosedPublic

Authored by nicolasfella on Nov 3 2018, 4:24 PM.

Details

Summary

Similar to what we do in the KCM. Show the name in a label and make it editable per button.

Test Plan

Rename device

Diff Detail

Repository
R224 KDE Connect
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella created this revision.Nov 3 2018, 4:24 PM
Restricted Application added a project: KDE Connect. · View Herald TranscriptNov 3 2018, 4:24 PM
Restricted Application added a subscriber: kdeconnect. · View Herald Transcript
nicolasfella requested review of this revision.Nov 3 2018, 4:24 PM
apol added a subscriber: apol.Nov 4 2018, 11:56 PM

Would it make sense to toggle the readOnly property? it would make the code simpler.

In D16639#354207, @apol wrote:

Would it make sense to toggle the readOnly property? it would make the code simpler.

That would make it uneditable, but it would still look like a text field, which is what I want to avoid

apol accepted this revision.Nov 5 2018, 12:55 AM

Are you sure? Oh well xD

This revision is now accepted and ready to land.Nov 5 2018, 12:55 AM
This revision was automatically updated to reflect the committed changes.