Don't crash if initializeVideo fails
ClosedPublic
Actions

Authored by fvogt on Nov 3 2018, 10:58 AM.

Details

Reviewers

broulik

Commits

R343:b8223de8e65d: Don't crash if initializeVideo fails

Summary

If avcodec_find_decoder returns NULL, a warning is printed and then NULL is
dereferenced later...

Test Plan

A user crashed thumbnail.so reproducably with a specific file.
Doesn't anymore with this patch applied.

Repository

R343 FFmpeg Thumbnailers

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

fvogt requested review of this revision.Nov 3 2018, 10:58 AM

fvogt created this revision.

This revision is now accepted and ready to land.Nov 3 2018, 3:12 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			ffmpegthumbnailer/moviedecoder.h (2 lines)
M			ffmpegthumbnailer/moviedecoder.cpp (14 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	44757	6fa26cd		Nov 3 2018, 10:58 AM	★	★
Diff 2	44776	6fa26cd	R343:b8223de8e65de6de08f2e29a398f0922fa282bbb	Nov 3 2018, 3:25 PM	★	★