[drm] Support transformation on CRTC in addition to primary plane
Needs ReviewPublic
Actions

Authored by graesslin on Nov 3 2018, 9:04 AM.

Details

Reviewers

None

Group Reviewers

Summary

So far we tried to rotate on the primary plane, but the feedback has
been that it doesn't work for 90 and 270 degrees. As crtc also supports
rotation this change refactors the functionality to provide rotation on
the crtc if the primary plane doesn't support it.

Unfortunately on my system this doesn't help: all crtcs report no
supported transformations. So either I did a mistake in the
initialization or someone else needs to test this patch.

Diff Detail

Repository

R108 KWin

Branch

transformation-on-crtc

Lint

Lint OK

Unit

No Unit Test Coverage

Build Status

Buildable 4502
Build 4520: arc lint + arc unit

graesslin created this revision.Nov 3 2018, 9:04 AM

Restricted Application added a project: KWin. · View Herald TranscriptNov 3 2018, 9:04 AM

Restricted Application added a subscriber: kwin. · View Herald Transcript

graesslin requested review of this revision.Nov 3 2018, 9:04 AM

Harbormaster completed remote builds in B4502: Diff 44755.Nov 3 2018, 9:04 AM

I will take a look at that and see if it works on one of my systems. Might take some time though.

So either I did a mistake in the initialization or someone else needs to test this patch.

I just tested and it didn't seem to behave for me. I didn't investigate further.

Revision Contents
Changeset List

			Path	Packages
M			plugins/platforms/drm/drm_object.h (15 lines)
M			plugins/platforms/drm/drm_object.cpp (24 lines)
M			plugins/platforms/drm/drm_object_crtc.h (4 lines)
M			plugins/platforms/drm/drm_object_crtc.cpp (24 lines)
M			plugins/platforms/drm/drm_object_plane.h (16 lines)
M			plugins/platforms/drm/drm_object_plane.cpp (25 lines)
M			plugins/platforms/drm/drm_output.h (1 line)
M			plugins/platforms/drm/drm_output.cpp (44 lines)