[Plasmoid] Clean up layout

Authored by ngraham on Nov 2 2018, 11:09 PM.



This patch cleans up the Search plasmoid's layout to essentially match that of KRunner (but without the side buttons).

It also cleans up the layout-related code a bit as there were some workarounds and hacks that are no longer needed.

Test Plan

Bottom panel, open:

Bottom panel, showing search results:

Top panel, open:

Top panel, showing search results:

Free-floating widget, open:

Free-floating widget, showing search results:

Diff Detail

R112 Milou
better-layout (branched from master)
No Linters Available
No Unit Test Coverage
Build Status
Buildable 4494
Build 4512: arc lint + arc unit
ngraham created this revision.Nov 2 2018, 11:09 PM
Restricted Application added a project: Plasma. · View Herald TranscriptNov 2 2018, 11:09 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Nov 2 2018, 11:09 PM
ngraham edited the summary of this revision. (Show Details)Nov 2 2018, 11:11 PM
ngraham edited the test plan for this revision. (Show Details)

I was a bit concerned at first that you jumped the gun for that but I admit I like that better than I thought I would. +1 from me

(when you're at it, can yo fix the separator lines for when it's in a bottom panel? :P)

ngraham updated this revision to Diff 44750.Nov 3 2018, 3:38 AM

Fix separator line placement when it's on a bottom panel (i.e. reversed)

Can we make the search box and the font on it bigger
Like Mac os spotlight

Can we make the search box and the font on it bigger
Like Mac os spotlight

We are just using the standard text box for this, so to make it bigger, we have only not-so-good options:

  • Use a custom control (bad: more code, will get out of sync with the common control over time)
  • Make the common control bigger (bad: will look out of place everywhere else)

I think we should stick with what we've got for now.

Is this good to go now?

davidedmundson accepted this revision.Nov 9 2018, 6:20 PM
davidedmundson added a subscriber: davidedmundson.

code is fine.

I don't have an opinion either way on the visuals.

This revision is now accepted and ready to land.Nov 9 2018, 6:20 PM

Thanks David!

This revision was automatically updated to reflect the committed changes.