[kstyle] Calculate correct size of scaled shadow pixmap
Changes PlannedPublic

Authored by zzag on Nov 2 2018, 9:32 PM.

Details

Reviewers
None
Group Reviewers
Plasma
Summary

This change slightly improves how widget style shadows look with
fractional scaling.

Test Plan

With some scale factors, there are still gaps between popups and shadows.

Diff Detail

Repository
R31 Breeze
Branch
zzag/fix-fractional-scaling
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 4491
Build 4509: arc lint + arc unit
zzag created this revision.Nov 2 2018, 9:32 PM
Restricted Application added a project: Plasma. · View Herald TranscriptNov 2 2018, 9:32 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
zzag requested review of this revision.Nov 2 2018, 9:32 PM
zzag added a comment.EditedNov 2 2018, 9:43 PM

Scale factor: 1.2

before:

after:

zzag edited the test plan for this revision. (Show Details)Nov 2 2018, 9:46 PM
zzag abandoned this revision.Nov 2 2018, 9:51 PM

Meh, there are more cases when we have to round.

zzag reclaimed this revision.Nov 2 2018, 10:34 PM

Hmm, it looks like TileSet chops the shadow pixmap incorrectly. (the rendered pixmap is correct)

zzag planned changes to this revision.Nov 2 2018, 10:35 PM