Differential D16615

Set appropriate icon for plasmoid
ClosedPublic
Actions

Authored by broulik on Nov 2 2018, 7:37 PM.

Details

Reviewers
ngraham
Group Reviewers
Plasma
Commits
R115:125c716889b9: Set appropriate icon for plasmoid
Summary

Widget explorer automatically uses the "preview" icon based on the plasmoid's name, so use an appropriate icon here that is shown in other parts of the UI, such as System Tray settings.

BUG: 400586
FIXED-IN: 5.14.3

Test Plan
  • volume plasmoid still shows "preview" in widget explorer
  • volume plasmoid now shows proper volume icon in system tray entries settings

Diff Detail

Repository
R115 Plasma Audio Volume Applet
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Nov 2 2018, 7:37 PM
Restricted Application added a project: Plasma. · View Herald TranscriptNov 2 2018, 7:37 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Nov 2 2018, 7:37 PM
ngraham accepted this revision.Nov 2 2018, 9:02 PM
This revision is now accepted and ready to land.Nov 2 2018, 9:02 PM
ngraham added a comment.Nov 2 2018, 9:03 PM

Wanna hit https://bugs.kde.org/show_bug.cgi?id=400587 too? Is the the same issue, just for plasma-nm. That way I can credit them both to you in this sunday's U&P blog post. :)

Closed by commit R115:125c716889b9: Set appropriate icon for plasmoid (authored by broulik). · Explain WhyNov 2 2018, 9:04 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mapplet/metadata.desktop (2 lines)

Diff 44729

View Options

applet/metadata.desktop

Loading...