Differential D1660

[Milou] Take label height into account for delegate height
ClosedPublic
Actions

Authored by broulik on May 23 2016, 4:29 PM.

Details

Reviewers
mart
Group Reviewers
Plasma
Commits
R112:bd14a260e651: [Milou] Take label height into account for delegate height
Summary

Font size and icon size are independent from each other (in contrast to spacing/gridUnit which depend on font) so it can happen that the font is disproportionately large compared to the icon resulting in squashed delegates.

BUG: 352696
FIXED-IN: 5.6.5

Test Plan

Works even with insanely large font now. The default delegate height is ever so slightly taller now but it makes the cramped list a bit more light-weight

Diff Detail

Repository
R112 Milou
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik updated this revision to Diff 3944.May 23 2016, 4:29 PM
broulik retitled this revision from to [Milou] Take label height into account for delegate height.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R112 Milou.
Restricted Application added a project: Plasma. · View Herald TranscriptMay 23 2016, 4:29 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart accepted this revision.May 24 2016, 7:16 AM
mart added a reviewer: mart.
This revision is now accepted and ready to land.May 24 2016, 7:16 AM
Closed by commit R112:bd14a260e651: [Milou] Take label height into account for delegate height (authored by broulik). · Explain WhyMay 24 2016, 7:54 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mlib/qml/ResultDelegate.qml (8 lines)

Diff 3952

View Options

lib/qml/ResultDelegate.qml

Loading...