Differential D16586

Simplify transient initialization in Deleted
ClosedPublic
Actions

Authored by zzag on Nov 1 2018, 11:16 AM.

Details

Reviewers
davidedmundson
Group Reviewers
KWin
Commits
R108:6a36c35d73e5: Simplify transient initialization in Deleted
Summary

AbstractClient::mainClients is quite generic, it can return either
transientFor parent or group member parents.

Test Plan

Existing tests still pass.

Diff Detail

Repository
R108 KWin
Branch
simplify-transient-initialization-in-deleted
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 4426
Build 4444: arc lint + arc unit
zzag created this revision.Nov 1 2018, 11:16 AM
Restricted Application added a project: KWin. · View Herald TranscriptNov 1 2018, 11:16 AM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Nov 1 2018, 11:16 AM
zzag planned changes to this revision.Nov 1 2018, 11:26 AM

oh, there's already m_mainClients.

zzag updated this revision to Diff 44623.Nov 1 2018, 11:29 AM

Use m_mainClients

davidedmundson accepted this revision.Nov 1 2018, 11:59 PM
davidedmundson added a subscriber: davidedmundson.
davidedmundson added inline comments.
deleted.cpp
126

may as well put it here

This revision is now accepted and ready to land.Nov 1 2018, 11:59 PM
zzag updated this revision to Diff 44694.Nov 2 2018, 9:53 AM

Put addTransientFor above

zzag updated this revision to Diff 44695.Nov 2 2018, 9:59 AM

fix typo

Closed by commit R108:6a36c35d73e5: Simplify transient initialization in Deleted (authored by zzag). · Explain WhyNov 2 2018, 10:05 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mdeleted.cpp (15 lines)

Diff 44622

View Options

deleted.cpp

Loading...