diff --git a/autotests/embeddedimagedatatest.h b/autotests/embeddedimagedatatest.h --- a/autotests/embeddedimagedatatest.h +++ b/autotests/embeddedimagedatatest.h @@ -33,6 +33,7 @@ private Q_SLOTS: void test(); + void test_data(); }; #endif // EMBEDDEDIMAGEDATATEST_H diff --git a/autotests/embeddedimagedatatest.cpp b/autotests/embeddedimagedatatest.cpp --- a/autotests/embeddedimagedatatest.cpp +++ b/autotests/embeddedimagedatatest.cpp @@ -35,6 +35,7 @@ void EmbeddedImageDataTest::test() { + QFETCH(QString, fileName); QMimeDatabase mimeDb; QString testAudioFile; EmbeddedImageData imageData; @@ -44,35 +45,40 @@ testFile.open(QIODevice::ReadOnly); originalFrontCoverImage = testFile.readAll(); - testAudioFile = testFilePath("test.opus"); + testAudioFile = testFilePath(fileName); QVERIFY(imageData.mimeTypes().contains(mimeDb.mimeTypeForFile(testAudioFile).name())); images = imageData.imageData(testAudioFile); QCOMPARE(images.value(EmbeddedImageData::FrontCover), originalFrontCoverImage); +} - testAudioFile = testFilePath("test.ogg"); - QVERIFY(imageData.mimeTypes().contains(mimeDb.mimeTypeForFile(testAudioFile).name())); - images = imageData.imageData(testAudioFile); - QCOMPARE(images.value(EmbeddedImageData::FrontCover), originalFrontCoverImage); +void EmbeddedImageDataTest::test_data() +{ + QTest::addColumn("fileName"); - testAudioFile = testFilePath("test.flac"); - QVERIFY(imageData.mimeTypes().contains(mimeDb.mimeTypeForFile(testAudioFile).name())); - images = imageData.imageData(testAudioFile); - QCOMPARE(images.value(EmbeddedImageData::FrontCover), originalFrontCoverImage); + QTest::addRow("opus") + << QStringLiteral("test.opus") + ; - testAudioFile = testFilePath("test.mp3"); - QVERIFY(imageData.mimeTypes().contains(mimeDb.mimeTypeForFile(testAudioFile).name())); - images = imageData.imageData(testAudioFile); - QCOMPARE(images.value(EmbeddedImageData::FrontCover), originalFrontCoverImage); + QTest::addRow("ogg") + << QStringLiteral("test.ogg") + ; - testAudioFile = testFilePath("test.m4a"); - QVERIFY(imageData.mimeTypes().contains(mimeDb.mimeTypeForFile(testAudioFile).name())); - images = imageData.imageData(testAudioFile); - QCOMPARE(images.value(EmbeddedImageData::FrontCover), originalFrontCoverImage); + QTest::addRow("flac") + << QStringLiteral("test.flac") + ; + + QTest::addRow("mp3") + << QStringLiteral("test.mp3") + ; + + QTest::addRow("m4a") + << QStringLiteral("test.m4a") + ; + + QTest::addRow("mpc") + << QStringLiteral("test.mpc") + ; - testAudioFile = testFilePath("test.mpc"); - QVERIFY(imageData.mimeTypes().contains(mimeDb.mimeTypeForFile(testAudioFile).name())); - images = imageData.imageData(testAudioFile); - QCOMPARE(images.value(EmbeddedImageData::FrontCover), originalFrontCoverImage); } QTEST_GUILESS_MAIN(EmbeddedImageDataTest)