Differential D16545

Fix warnings about nullptr for flags
ClosedPublic
Actions

Authored by volkov on Oct 31 2018, 2:39 PM.

Details

Reviewers
danders
Group Reviewers
KDiagram
Commits
R478:f4013f88af6c: Fix warnings about nullptr for flags
Summary

Use QFlags::QFlags() ctor instead of 0.

Diff Detail

Repository
R478 KDiagram: Libraries for diagrams
Branch
qflags-nullptr
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 4366
Build 4384: arc lint + arc unit
volkov requested review of this revision.Oct 31 2018, 2:39 PM
volkov created this revision.
tbaumgart added a subscriber: tbaumgart.Oct 31 2018, 9:03 PM
tbaumgart added inline comments.
examples/DrawIntoPainter/framewidget.h
35

Shouldn't it be parent = nullptr additionally? I did not mark all the other instances in this patch.

danders accepted this revision.Nov 1 2018, 7:01 AM
danders added a subscriber: danders.

Yes, I have patch for nullptr, not pushed yet.

This revision is now accepted and ready to land.Nov 1 2018, 7:01 AM
volkov closed this revision.Nov 1 2018, 10:57 AM

Revision Contents
Changeset List

Diff 44547

View Options

examples/DrawIntoPainter/framewidget.h

Loading...
View Options

examples/Gantt/legend_example/entrydialog.h

Loading...
View Options

examples/Gantt/legend_example/mainwindow.h

Loading...
View Options

qtests/DrawIntoPainter/framewidget.h

Loading...
View Options

src/KChart/KChartChart.cpp

Loading...
View Options

src/KChart/KChartLayoutItems.h

Loading...
View Options

src/KChart/KChartLayoutItems.cpp

Loading...
View Options

tests/Gantt/apireview/entrydialog.h

Loading...
View Options

tests/Gantt/apireview/mainwindow.h

Loading...