Drop X11 core fonts code from startkde/startplasma
ClosedPublic

Authored by bruns on Oct 30 2018, 5:03 PM.

Details

Summary

Qt and GTK based applications have switched to using fontconfig for fonts
exclusively, so this code is mostly unused.

As for the remaining legacy X11 applications:

  • mkfontdir only supports bitmap (e.g. PCF, BDF) fonts. For e.g. truetype fonts, a mkfontscale call would be required. Lack of complaints hints this is not used at all.
  • the system dirs (sys_odir, sys_fdir) use KDEDIR(S), which is deprecated. The dirs do not exist, thus the fontpath is unchanged.
  • system dirs are typically allready included in the XServer font path

TLDR: (scalable) fonts in user dirs are not picked up due to missing
mkfontscale calls, and system dirs are already included.

This removes the dependency on xset and mkfontdir. The latter is important,
as e.g. on openSUSE the availability of mkfontdir triggers costly, extra
setup steps for X Core fonts on package installation.

Diff Detail

Repository
R120 Plasma Workspace
Branch
drop_x_core_font_support
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 4347
Build 4365: arc lint + arc unit
bruns created this revision.Oct 30 2018, 5:03 PM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 30 2018, 5:03 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
bruns requested review of this revision.Oct 30 2018, 5:03 PM
bruns added a comment.Nov 6 2018, 3:36 PM

Friendly reminder ...

fvogt added a comment.Nov 6 2018, 3:51 PM

Looks good to me, but I don't know enough about old X11 stuff like this to accept it.

bruns added a comment.Nov 8 2018, 9:58 PM

Looks good to me, but I don't know enough about old X11 stuff like this to accept it.

@fvogt - maybe you can poke a coworker?

Someone else?

It's always tricky when you remove old stuff; we don't want to risk any changes that could affect a usecase no matter how obscure.
It's not something to rush or do lightly.

However, your rationale makes sense. There's an additional pieces of information that I think helps me reach a decision.

kfontinst (the font install kcm) does call mkfontscale/mkfontdir

If they don't use kfontinst to install fonts that's their problem. No reason for us to do it on load

Ship it!

(FWIW, here is when it was added: https://websvn.kde.org/?view=revision&revision=37745)

davidedmundson accepted this revision.Nov 8 2018, 11:54 PM
This revision is now accepted and ready to land.Nov 8 2018, 11:54 PM
This revision was automatically updated to reflect the committed changes.