hello?

Using timers doesn't seem like a good idea to me.

How much events do you get? What's the delta of each event?

I tried this on my ThinkPad Yoga 12, which comes with a stylus to write on the screen with. I confirm that this patch noticeably improves the scrolling behavior when using the stylus for scrolling.

I am curious though: what are the downsides to enabling tablet event compression? When would I want to disable it?

Hi, thanks for the feedback.

I think uncompressed tablet events are useful for example on krita, when you don't want to lose the "high frequency" content of the drawing on the screen, and latency is not a big issue.
I don't see any downsides for okular, mouse events are already compressed, this patch only fixes a Qt "documented quirk"

I do use my stylus for drawing on slides in presentation mode. I am not particularly happy with the quality of that, but compressing tablet events doesn't seem to make it worse. So no objections from my side.

Ping

In D16519#443932, @ngraham wrote:

Works better for me too on my HP Spectre x360, and I couldn't find any regressions in behavior.

@kezik can you provide your full name and email address so we can land this patch with correct authorship information? Thanks!

Thanks

I don't want to disclose my full name, email is keziolio123@gmail.com and you can put "kezi" as the name

I had to do "Kezi Olio" to pass the commit filters which demand a two-part name, hope you don't mind.

In D16519#443979, @ngraham wrote:

I had to do "Kezi Olio" to pass the commit filters which demand a two-part name, hope you don't mind.

Perfect
Thanks

Please never ever again land commits of anonymous people. If somewhen we want to relicense we're fucked.

In D16519#444415, @aacid wrote:

Please never ever again land commits of anonymous people. If somewhen we want to relicense we're fucked.

We've had this conversation before and I recall the conclusion being that as long as we have a real and legitimate email address, things are good. We're currently actively accepting commits from "Nerdopolis Turfwalker" to KWin and "Loh Tar" to Kate and KTextEditor, both of whom use pseudonyms with real email addresses. Each time eyebrows were raised but the conclusion was that real names are optional but email addresses must be real. If you disagree with this, then probably it's time for another mailing list thread.

@kezik if you wish to record your relicensing preferences, please submit a patch to add yourself and your preferences to https://cgit.kde.org/kde-dev-scripts.git/tree/relicensecheck.pl

That's your (plural) conclusion not mine, i disagree with that conclusion so i will voice my concern each time that happens.

Ok, well seeing as @kezik is continuing to submit patches (see D20437), I guess your options are to:

1. Try to convince him/her to provide a real name and re-open the discussion on a mailing list or phab task
2. Gracefully accept a conclusion you don't agree with
3. Throw away the contributions

In D16519#447479, @ngraham wrote:

Ok, well seeing as @kezik is continuing to submit patches (see D20437), I guess your options are to:

1. re-open the discussion on a mailing list or phab task

I don't know what makes you think *I* should be the one re-open the discussion on a mailing list or phab task, AFAIR *you* are the first person ever to commit hard to trace commits to Okular repo, so it's on *you* to show why we have to agree to such tainting.

In D16519#447765, @aacid wrote:

In D16519#447479, @ngraham wrote:

Ok, well seeing as @kezik is continuing to submit patches (see D20437), I guess your options are to:

1. re-open the discussion on a mailing list or phab task

I don't know what makes you think *I* should be the one re-open the discussion on a mailing list or phab task, AFAIR *you* are the first person ever to commit hard to trace commits to Okular repo, so it's on *you* to show why we have to agree to such tainting.

OK, I have done so: https://mail.kde.org/pipermail/kde-community/2019q2/005296.html