Eventviews: simplify/modernize resource color code
ClosedPublic

Authored by dfaure on Oct 29 2018, 10:11 AM.

Details

Summary

This commit does not change behaviour in any way (except the behaviour
of the reader, who can now understand what he/she is reading)

Test Plan

Restarting korganizer, colors unchanged.

Diff Detail

Repository
R76 PIM: Event Views
Branch
2018_10_refactor (branched from Applications/18.08)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 4307
Build 4325: arc lint + arc unit
dfaure created this revision.Oct 29 2018, 10:11 AM
Restricted Application added a project: KDE PIM. · View Herald TranscriptOct 29 2018, 10:11 AM
Restricted Application edited subscribers, added: kde-pim; removed: KDE PIM. · View Herald Transcript
dfaure requested review of this revision.Oct 29 2018, 10:11 AM

I haven't tried the code but it seems good to me. And way more understandable.

A "Ship it" from me.

src/prefs.cpp
172

Remove dead code

ochurlaud accepted this revision.Oct 30 2018, 7:38 PM
This revision is now accepted and ready to land.Oct 30 2018, 7:38 PM
dfaure closed this revision.Oct 31 2018, 3:44 PM
dfaure added inline comments.Oct 31 2018, 3:47 PM
src/prefs.cpp
172

I find it convenient to have ready-to-use debug output around when debugging, actually.